[lkml]   [2012]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RESEND PATCH v2 0/2] power_supply: update Charger-Manager
    On Tue, Apr 24, 2012 at 07:47:24PM +0900, Chanwoo Choi wrote:
    > Documentation/power/charger-manager.txt | 41 +++-
    > drivers/power/charger-manager.c | 391
    > +++++++++++++++++++++++++++++++
    > include/linux/power/charger-manager.h | 49 ++++-
    > 3 files changed, 471 insertions(+), 10 deletions(-)

    Applied, thanks!

    Note that the patches were word-wrap damaged, I had to fix them by
    hand. The file 'linux/Documentation/email-clients.txt' contains some
    useful tips for setting up commonly used mail clients. You might
    also try using 'git send-email'.

    While looking through the CM code, I noticed that cm uevents
    are not friendly wrt several chargers (the code has static variables
    in the uevent_notify() func).

    Also, what's the rationale behind implementing own uevent handling,
    and not using power_supply uevents (see power_supply_sysfs.c
    and power_supply_changed() thing)? Also, you don't seem to
    report variables in the uevent, but just messages. That's unusual.


    Anton Vorontsov

     \ /
      Last update: 2012-05-06 05:41    [W:0.022 / U:9.940 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site