[lkml]   [2012]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/3] MFD: twl6040: Allocate IRQ numbers dynamically
    On 05/04/2012 12:08 PM, Mark Brown wrote:
    > You're not understanding the issue at all - the issue is that if
    > some driver outside the twl6040 driver is using an interrupt in that
    > range based off the irq_base that they supplied then you'll break them.
    > The most common case here is using GPIOs on the device as interrupts.

    The OMAP platform related drives has been already converted to use
    irq_alloc_descs(-1, 0, nr_irqs, 0); to map their range (including GPIO,
    twl6030, etc).
    Neither of these are using or have irq_base passed from board files for
    some time now. We still have the defines for the legacy define based
    mapping of the ranges, but it is no longer in use.
    To be fair: in arch/arm/mach-omap2/ there's one driver which has not
    been converted. It is the gpmc (Flash).

    > If this is safe you should at least be making it clear why...

    I'll add short explanation to the commit message.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2012-05-04 12:41    [W:0.021 / U:383.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site