lkml.org 
[lkml]   [2012]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: drivers: Probable misuses of ||
    From
    Date
    On Fri, 2012-05-04 at 23:56 +0100, Alan Cox wrote:
    > On Fri, 04 May 2012 14:54:37 -0700
    > Joe Perches <joe@perches.com> wrote:
    >
    > > On Wed, 2012-04-04 at 16:00 -0700, Joe Perches wrote:
    > > > Likely these should be && not ||
    > > >
    > > > drivers/scsi/FlashPoint.c: if(bit_cnt != 0 || bit_cnt != 8)
    > >
    > > It's been a month.
    > >
    > > Do you maintainers not care about these obvious defects?
    >
    > You are assuming the code in question has maintainers.

    Nope. I'm assuming the nominal subsystem maintainers
    haven't bothered to look at it or are in "don't care"
    mode and I am simply prompting people to look again.

    Richard Weinberger replied showing that the flashpoint
    bit was commented out. Thanks Richard.

    cheers, Joe




    \
     
     \ /
      Last update: 2012-05-05 01:41    [W:0.022 / U:30.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site