lkml.org 
[lkml]   [2012]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: drivers: Probable misuses of ||
    From
    Date
    On Fri, 2012-05-04 at 23:02 +0100, Mark Brown wrote:
    > On Fri, May 04, 2012 at 02:54:37PM -0700, Joe Perches wrote:
    > > On Wed, 2012-04-04 at 16:00 -0700, Joe Perches wrote:
    >
    > > > drivers/media/dvb/dvb-usb/it913x.c: if (ret == 0 || ret != -EBUSY || ret != -ETIMEDOUT)
    > > > drivers/media/dvb/dvb-usb/it913x.c: if (ret == 0 || ret != -EBUSY || ret != -ETIMEDOUT)
    > > > drivers/media/rc/fintek-cir.c: if ((chip != 0x0408) || (chip != 0x0804))
    >
    > > It's been a month.
    >
    > > Do you maintainers not care
    > > about these obvious defects?
    >
    > It'd probably help if you were to supply more analysis as to what the
    > issues you think you're seeing are - in the cases quoted above
    > (especially the last one) there's no obvious bug without further
    > analysis.

    Likely the || should be &&.

    if (val != foo || test != bar)

    is always true when foo != bar




    \
     
     \ /
      Last update: 2012-05-05 00:41    [W:0.024 / U:62.568 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site