lkml.org 
[lkml]   [2012]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] cciss: fix incorrect scsi status reporting
    From
    Date
    From: Stephen M. Cameron <scameron@beardog.cce.hp.com>

    Delete code which sets SCSI status incorrectly as it's already
    been set correctly above this incorrect code. Bug was introduced
    by b0e15f6db1110319cb2e747e59e1200450a5ba3e
    "cciss: fix typo that causes scsi status to be lost." in 2009.

    Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
    Reported-and-tested-by: Roel van Meer <roel.vanmeer@bokxing.nl>
    Cc: stable@vger.kernel.org
    ---
    drivers/block/cciss_scsi.c | 11 +----------
    1 files changed, 1 insertions(+), 10 deletions(-)

    diff --git a/drivers/block/cciss_scsi.c b/drivers/block/cciss_scsi.c
    index acda773..38aa6dd 100644
    --- a/drivers/block/cciss_scsi.c
    +++ b/drivers/block/cciss_scsi.c
    @@ -763,16 +763,7 @@ static void complete_scsi_command(CommandList_struct *c, int timeout,
    {
    case CMD_TARGET_STATUS:
    /* Pass it up to the upper layers... */
    - if( ei->ScsiStatus)
    - {
    -#if 0
    - printk(KERN_WARNING "cciss: cmd %p "
    - "has SCSI Status = %x\n",
    - c, ei->ScsiStatus);
    -#endif
    - cmd->result |= (ei->ScsiStatus << 1);
    - }
    - else { /* scsi status is zero??? How??? */
    + if (!ei->ScsiStatus) {

    /* Ordinarily, this case should never happen, but there is a bug
    in some released firmware revisions that allows it to happen


    \
     
     \ /
      Last update: 2012-05-04 20:41    [W:0.043 / U:0.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site