lkml.org 
[lkml]   [2012]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv3 3/4] iommu/tegra: smmu: Refrain from accessing to AHB
On 05/04/2012 12:33 AM, Hiroshi Doyu wrote:
> Stephen Warren wrote at Thu, 3 May 2012 19:48:25 +0200:
>> On 05/03/2012 10:05 AM, Hiroshi DOYU wrote:
>>> Use "tegra_ahb_enable_smmu()" to inform AHB that SMMU is
>>> ready, instead of directly aceessing AHB registers.
...
>>> @@ -911,14 +899,16 @@ static int tegra_smmu_probe(struct platform_device *pdev)
>>
>>> + smmu->ahb = of_parse_phandle(pdev->dev.of_node, "ahb", 0);
>>
>> Hmm, "ahb" should probably be "nvidia,ahb".
>
> Does this mean the following in dts?
>
> ahb: ahb@6000c004 {
> compatible = "nvidia,tegra30-ahb";
> reg = <0x6000c004 0x14c>; /* AHB Arbitration + Gizmo Controller */
> };
>
> smmu: smmu@7000f000 {
> nvidia,ahb = &ahb;
> }; ^^^^^^^^^^
>

Yes.


\
 
 \ /
  Last update: 2012-05-04 19:01    [W:0.092 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site