Messages in this thread | | | Date | Fri, 4 May 2012 18:41:18 +0200 | From | Jiri Olsa <> | Subject | Re: [patch] perf: Fix build failure on OpenSuse userspace |
| |
On Sat, May 05, 2012 at 12:38:48AM +0900, Namhyung Kim wrote: > Hi, > > On Fri, 4 May 2012 17:26:13 +0200, Jiri Olsa wrote: > > On Fri, May 04, 2012 at 12:10:55PM -0300, Lucas De Marchi wrote: > >> Nah. What you need is -Wno-sign-compare. > >> > >> But you are better off overriding the CFLAGS for these generated > >> files. Just put -Wno-error as the last one (untested, but should work) > > > > yep, I think it's good idea.. and plus '-w' to suppres warnings not to > > polute the build log > > > > jirka > > Works well for me. But I guess -Wno-error turns into a nop if we use > '-w', right?
argghh.. right ;) misread the man page.. I tested -w is enough
thanks, jirka
> > > Thank, > Namhyung > > > > > > > > --- > > diff --git a/tools/perf/Makefile b/tools/perf/Makefile > > index 7055a00..9c734a2 100644 > > --- a/tools/perf/Makefile > > +++ b/tools/perf/Makefile > > @@ -729,10 +729,10 @@ $(OUTPUT)perf.o perf.spec \ > > # over the general rule for .o > > > > $(OUTPUT)util/%-flex.o: $(OUTPUT)util/%-flex.c $(OUTPUT)PERF-CFLAGS > > - $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) -Iutil/ -Wno-redundant-decls -Wno-switch-default -Wno-unused-function $< > > + $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) -Iutil/ -Wno-error -w $< > > > > $(OUTPUT)util/%-bison.o: $(OUTPUT)util/%-bison.c $(OUTPUT)PERF-CFLAGS > > - $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -Iutil/ -Wno-redundant-decls -Wno-switch-default -Wno-unused-function $< > > + $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -Iutil/ -Wno-error -w $< > > > > $(OUTPUT)%.o: %.c $(OUTPUT)PERF-CFLAGS > > $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) $<
| |