lkml.org 
[lkml]   [2012]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/4] usb: gadget: pch_udc: Fix likely misuse of | for &
    On Wed, May 30, 2012 at 01:25:57PM -0700, Joe Perches wrote:
    > Using | with a constant is always true.
    > Likely this should have be &.
    >
    > Signed-off-by: Joe Perches <joe@perches.com>

    this looks good to me. Do you want me to carry it on my tree ?

    If you want to carry it out as a fix:

    Acked-by: Felipe Balbi <balbi@ti.com>

    > ---
    > drivers/usb/gadget/pch_udc.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c
    > index 1cfcc9e..f4fb71c 100644
    > --- a/drivers/usb/gadget/pch_udc.c
    > +++ b/drivers/usb/gadget/pch_udc.c
    > @@ -2208,7 +2208,7 @@ static void pch_udc_complete_receiver(struct pch_udc_ep *ep)
    > return;
    > }
    > if ((td->status & PCH_UDC_BUFF_STS) == PCH_UDC_BS_DMA_DONE)
    > - if (td->status | PCH_UDC_DMA_LAST) {
    > + if (td->status & PCH_UDC_DMA_LAST) {
    > count = td->status & PCH_UDC_RXTX_BYTES;
    > break;
    > }
    > --
    > 1.7.8.111.gad25c.dirty
    >

    --
    balbi
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-05-31 10:01    [W:0.027 / U:1.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site