lkml.org 
[lkml]   [2012]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] RAS: Add a tracepoint for reporting memory controller events
    On Thu, May 31, 2012 at 03:32:52PM -0400, Steven Rostedt wrote:
    > Just so I understand your point. You are saying things like grain that
    > don't change but are different per device, should just be in some sysfs
    > file somewhere, and things that are dynamic during runtime should go
    > into the tracepoint.

    Right, for the majority of edac drivers, grain is a static value
    assigned once per driver initialization.

    Then there are other drivers which report different grain per error.

    Now, all I'm saying is, the static ones should report grain once when
    the driver inits in dmesg or in sysfs and _not_ report grain in each
    tracepoint invocation - we don't want to waste space in the ring buffer
    for information which never or only very seldom changes.

    For the drivers where grain is per error, they report it in the
    tracepoint (and only they!) as part of the driver-specific char string.

    This way all is fair and no space in the ring buffer gets wasted.

    Makes sense?

    --
    Regards/Gruss,
    Boris.

    Advanced Micro Devices GmbH
    Einsteinring 24, 85609 Dornach
    GM: Alberto Bozzo
    Reg: Dornach, Landkreis Muenchen
    HRB Nr. 43632 WEEE Registernr: 129 19551


    \
     
     \ /
      Last update: 2012-05-31 22:01    [W:4.122 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site