Messages in this thread | | | Date | Thu, 31 May 2012 12:12:42 +0200 (CEST) | From | Joel Reardon <> | Subject | Re: [PATCH v2] UBIFS: compute KSA size and store in superblock |
| |
> You need to validate that: > > 1. if use_ubifsec is true, then ksa_lebs is not zero. > 2. ksa_lebs is sane - not too small, not too large. >
Will add an assert and a dbg check function.
> > diff --git a/fs/ubifs/ubifs-media.h b/fs/ubifs/ubifs-media.h > > index 90f348c..1dda25d 100644 > > --- a/fs/ubifs/ubifs-media.h > > +++ b/fs/ubifs/ubifs-media.h > > @@ -618,10 +618,13 @@ struct ubifs_pad_node { > > * @rp_uid: reserve pool UID > > * @rp_gid: reserve pool GID > > * @rp_size: size of the reserved pool in bytes > > - * @padding2: reserved for future, zeroes > > Do not remove this comment. >
I only moved it, new fields were added to the struct and it was not longer in the correct place in the comment.
> > * @time_gran: time granularity in nanoseconds > > * @uuid: UUID generated when the file system image was created > > * @ro_compat_version: UBIFS R/O compatibility version > > + * @crypto_lebs: number of LEBS being used to store keys > > + * @use_ubifsec: the LSB signifies whether the file system should use secure > > + * deletion > > + * @padding2: reserved for future, zeroes > > */
Cheers, Joel Reardon
| |