lkml.org 
[lkml]   [2012]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] crypto: serpent - add x86_64/avx assembler implementation
Quoting Andi Kleen <andi@firstfloor.org>:

>
> The driver needs CPUID annotations now (since 3.3), so that it can be
> autoloaded. Something like:
>

Is it really good idea to autoload crypto modules? Currently loading
different cipher implementations is handled via module-aliases and
cipher priorities. With autoloading by CPUID, crypto-modules would be
loaded and be mostly unused. For example, serpent-sse2 would be
autoloaded on all x86-64 kernels (well, on those that have it compiled
as module => probably most of distros).
IMHO these should be loaded only when needed, as is done with generic
i586/x86-64 assembler cipher implementations.

-Jussi



\
 
 \ /
  Last update: 2012-05-30 10:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site