lkml.org 
[lkml]   [2012]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 4/5] x86: Allow nesting of the debug stack IDT setting
    From: Steven Rostedt <srostedt@redhat.com>

    When the NMI handler runs, it checks if it preempted a debug handler
    and if that handler is using the debug stack. If it is, it changes the
    IDT table not to update the stack, otherwise it will reset the debug
    stack and corrupt the debug handler it preempted.

    Now that ftrace uses breakpoints to change functions from nops to
    callers, many more places may hit a breakpoint. Unfortunately this
    includes some of the calls that lockdep performs. Which causes issues
    with the debug stack. It too needs to change the debug stack before
    tracing (if called from the debug handler).

    Allow the debug_stack_set_zero() and debug_stack_reset() to be nested
    so that the debug handlers can take advantage of them too.

    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    arch/x86/kernel/cpu/common.c | 8 +++++++-
    1 file changed, 7 insertions(+), 1 deletion(-)

    diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
    index 82f29e7..63fc083 100644
    --- a/arch/x86/kernel/cpu/common.c
    +++ b/arch/x86/kernel/cpu/common.c
    @@ -1101,14 +1101,20 @@ int is_debug_stack(unsigned long addr)
    addr > (__get_cpu_var(debug_stack_addr) - DEBUG_STKSZ));
    }

    +static DEFINE_PER_CPU(atomic_t, debug_idt_zero);
    +
    void debug_stack_set_zero(void)
    {
    + atomic_inc(&__get_cpu_var(debug_idt_zero));
    load_idt((const struct desc_ptr *)&nmi_idt_descr);
    }

    void debug_stack_reset(void)
    {
    - load_idt((const struct desc_ptr *)&idt_descr);
    + if (WARN_ON(!atomic_read(&__get_cpu_var(debug_idt_zero))))
    + return;
    + if (atomic_dec_and_test(&__get_cpu_var(debug_idt_zero)))
    + load_idt((const struct desc_ptr *)&idt_descr);
    }

    #else /* CONFIG_X86_64 */
    --
    1.7.10

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-05-31 04:41    [W:0.037 / U:30.272 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site