Messages in this thread | | | Subject | Re: [PATCH 2/2] x86 mce: use new printk recursion disabling interface | From | Yanmin Zhang <> | Date | Thu, 31 May 2012 08:30:36 +0800 |
| |
On Wed, 2012-05-30 at 11:08 +0200, Borislav Petkov wrote: > On Mon, May 28, 2012 at 10:07:59AM +0800, ShuoX Liu wrote: > > Boris, > > I checked code and found some other functions in do_machine_check() also > > would printk something. Such as add_taint(). So i think we'd better > > place the recursion check at the beginning and the end of > > do_machine_check(). Also more printks later(maybe) added will benefit > > from this. Do you agree? > > I'm not sure we want to disable printk recursion for add_taint() - it > doesn't spit out any useful information wrt MCE so we could ignore it. add_taint might be not a good case here. We could move the recursion check flag setting around mce_panic.
> > Btw, I forgot to ask: this printk recursion disabling, do you have a > real usecase where you don't get the MCE info in dmesg and with your > patch it works or is this purely hypothetical? We hit it when running a MTBF testing on a Android atom mobile.
Thanks, Yanmin
| |