lkml.org 
[lkml]   [2012]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [GIT PULL] Block driver bits for 3.5
    Eric, can you verify that reverting that one commit on top of current
    -git fixes things for you?

    I'm a bit surprised that it would be that simple commit that actually
    just *removes* a mutex use that causes it, so the bisect result looks
    a bit fishy. Maybe it's a race that doesn't always cause the lockup at
    boot, in which case it might have bisected to the wrong thing..

    But if reverting that commit from top-of-tree fixes it, that's pretty
    unambiguous.

    Linus

    On Wed, May 30, 2012 at 1:35 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
    > commit d3ca8b64b97ef4dc54d7bb0b88bbc01a1fca8cb9
    > Author: Alan Cox <alan@linux.intel.com>
    > Date:   Tue May 29 13:45:01 2012 +0100
    >
    >    pty: Fix lock inversion
    >
    >    The ptmx_open path takes the tty and devpts locks in the wrong order
    >    because tty_init_dev locks and returns a locked tty.  As far as I can
    >    tell this is actually safe anyway because the tty being returned is new
    >    so nobody can get a reference to lock it at this point.
    >
    >    However we don't even need the devpts lock at this point, it's only held
    >    as a byproduct of the way the locks were pushe down.
    >
    >    Signed-off-by: Alan Cox <alan@linux.intel.com>
    >    Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    >    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    >
    >
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-30 23:41    [W:0.060 / U:59.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site