Messages in this thread |  | | | Date | Tue, 29 May 2012 22:56:18 -0700 | | From | John Stultz <> | | Subject | Re: [PATCH RFC V2 3/6] time: keep track of the pending utc/tai threshold |
| |
On 05/29/2012 10:11 PM, Richard Cochran wrote: > On Tue, May 29, 2012 at 06:49:30PM -0700, John Stultz wrote: >> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c >> index 6e46cac..81c76a9 100644 >> --- a/kernel/time/timekeeping.c >> +++ b/kernel/time/timekeeping.c >> @@ -962,6 +962,7 @@ static cycle_t logarithmic_accumulation(cycle_t offset, int shift) >> timekeeper.xtime.tv_sec++; >> leap = second_overflow(timekeeper.xtime.tv_sec); >> timekeeper.xtime.tv_sec += leap; >> + timekeeper.wall_to_monotonic.tv_sec -= leap; > Don't you need this in update_wall_time() too? Yep. Good point.
> BTW I suggest refactoring this code (two almost identical if{} bodies) > into a shared helper function. > Sounds good, although since the logic is ever so slightly different I might split up the pure fix and do the refactoring later so the fix is easier to apply to -stable branches.
thanks -john
|  |