[lkml]   [2012]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/6] Revert "mm: mempolicy: Let vma_merge and vma_split handle vma->vm_policy linkages"
On Wed, 30 May 2012, wrote:

> From: KOSAKI Motohiro <>
> commit 05f144a0d5 removed vma->vm_policy updates code and it is a purpose of
> mbind_range(). Now, mbind_range() is virtually no-op. no-op function don't
> makes any bugs, I agree. but maybe it is not right fix.

I dont really understand the changelog. But to restore the policy_vma() is
the right thing to do since there are potential multiple use cases where
we want to apply a policy to a vma.

Proposed new changelog:

Commit 05f144a0d5 folded policy_vma() into mbind_range(). There are
other use cases of policy_vma(*) though and so revert a piece of
that commit in order to have a policy_vma() function again.

> @@ -655,23 +676,9 @@ static int mbind_range(struct mm_struct *mm, unsigned long start,
> if (err)
> goto out;
> }
> -
> - /*
> - * Apply policy to a single VMA. The reference counting of
> - * policy for vma_policy linkages has already been handled by
> - * vma_merge and split_vma as necessary. If this is a shared
> - * policy then ->set_policy will increment the reference count
> - * for an sp node.
> - */

You are dropping the nice comments by Mel that explain the refcounting.

 \ /
  Last update: 2012-05-30 21:41    [W:1.057 / U:3.228 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site