lkml.org 
[lkml]   [2012]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] crypto: serpent - add x86_64/avx assembler implementation
On Wed, May 30, 2012 at 06:26:45PM +0200, Andi Kleen wrote:
> > I tried to be consistent with the existing ciphers in arch/x86/crypto.
> > In serpent_sse2_glue.c and sha1_ssse3_glue.c it is done exactly that way, so if
> > it will be decided to remove the printk in this patch it probably should also
> > be removed in the other modules.
>
>
> They are wrong and need to be fixed.
>
> Drivers can be loaded for all kinds of reasons, but they are not supposed
> to spam your kernel log when they do nothing.
>
> In fact I fixed all the existing ones with the cpuid changes, unfortunately
> somehow snuck in wrong code :-(

Hm, ok, removing the printk stuff is no big deal. I would fix this together
with the cpuid probing, when I'm sure that this is the preferred "new" way :-)

- Johannes


\
 
 \ /
  Last update: 2012-05-30 20:01    [W:0.086 / U:0.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site