Messages in this thread |  | | | From | "Liu, Jinsong" <> | | Subject | RE: [Xen-devel] [PATCH 1/3] xen/mce: Add mcelog support for Xen platform (v2) | | Date | Wed, 30 May 2012 15:14:57 +0000 |
| |
Konrad Rzeszutek Wilk wrote: >> An approach which basically same as you suggested but w/ slightly >> update, is 1). at xen/mcelog.c, do >> misc_register(&xen_mce_chrdev_device) at xen_late_init_mcelog, >> define it as device_initcall(xen_late_init_mcelog) --> now linux dd >> ready, so xen mcelog divice would register successfully; > > OK. >> 2). at native mce.c, change 1 line from >> device_initcall(mcheck_init_device) to >> device_initcall_sync(mcheck_init_device) --> so >> misc_register(&mce_chrdev_device) would be blocked by xen mcelog >> device; > > You mean that the registration would be delayed to the next initcall > level. > Ok, that sounds right.. but you also need to actually check the > 'misc_register' return value and if it fails (which it would in this > case) unroll all the registration > that the generic code I think?
Hmm, this patch blocked AMD mce logic, it's unacceptable.
Thanks, Jinsong
> >> >> I have draft test it and works fine. >> Thought? >> >> Thanks, >> Jinsong >> -- >> To unsubscribe from this list: send the line "unsubscribe >> linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/
|  |