lkml.org 
[lkml]   [2012]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] remoteproc: remove the now-redundant kref
On 5/26/2012 12:36 AM, Ohad Ben-Cohen wrote:
> /* will be called when an rproc is added to the rprocs klist */
> static void klist_rproc_get(struct klist_node *n)
> {
> struct rproc *rproc = container_of(n, struct rproc, node);
>
> - kref_get(&rproc->refcount);
> + get_device(&rproc->dev);
> }
>
> /* will be called when an rproc is removed from the rprocs klist */
> @@ -1312,7 +1282,7 @@ static void klist_rproc_put(struct klist_node *n)
> {
> struct rproc *rproc = container_of(n, struct rproc, node);
>
> - kref_put(&rproc->refcount, rproc_release);
> + put_device(&rproc->dev);
> }
>
> static struct rproc *next_rproc(struct klist_iter *i)
> @@ -1354,7 +1324,7 @@ struct rproc *rproc_get_by_name(const char *name)
> klist_iter_init(&rprocs, &i);
> while ((rproc = next_rproc(&i)) != NULL)
> if (!strcmp(rproc->name, name)) {
> - kref_get(&rproc->refcount);
> + get_device(&rproc->dev);
> break;
> }
> klist_iter_exit(&i);
> @@ -1367,7 +1337,7 @@ struct rproc *rproc_get_by_name(const char *name)
>
> ret = rproc_boot(rproc);
> if (ret < 0) {
> - kref_put(&rproc->refcount, rproc_release);
> + put_device(&rproc->dev);
> return NULL;
> }

I was hoping we could use class_for_each_device() and
class_find_device() to replace all this code. Then we wouldn't need all
this klist stuff that the class is taking care of already.

> @@ -1462,10 +1432,23 @@ int rproc_register(struct rproc *rproc)
> }
> EXPORT_SYMBOL(rproc_register);
>
> +/**
> + * rproc_class_release() - release a remote processor instance
> + * @dev: the rproc's device
> + *
> + * This function should _never_ be called directly.
> + *
> + * It will be called by the driver core when no one holds a valid pointer
> + * to @dev anymore.
> + */

Why is this added now and not in the previous patch?

> static void rproc_class_release(struct device *dev)
> {
> struct rproc *rproc = container_of(dev, struct rproc, dev);
>
> + dev_info(&rproc->dev, "releasing %s\n", rproc->name);
> +
> + rproc_delete_debug_dir(rproc);
> +
> idr_remove_all(&rproc->notifyids);
> idr_destroy(&rproc->notifyids);
>
[snip]
> @@ -1603,8 +1584,8 @@ int rproc_unregister(struct rproc *rproc)
>
> device_del(&rproc->dev);
>
> - /* the rproc will only be released after its refcount drops to zero */
> - kref_put(&rproc->refcount, rproc_release);
> + /* unroll rproc_alloc. TODO: we may want to let the users do that */
> + put_device(&rproc->dev);

Yes I think we want rproc_free() to actually call put_device() the last
time and free the resources.

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.



\
 
 \ /
  Last update: 2012-05-30 11:21    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site