lkml.org 
[lkml]   [2012]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay
    On 2012年05月03日 16:09, Benjamin Herrenschmidt wrote:
    > On Thu, 2012-05-03 at 14:59 +0800, Wang Sheng-Hui wrote:
    >> On 2012年05月03日 14:33, Wang Sheng-Hui wrote:
    >>> if (unlikely(irq_happened != PACA_IRQ_HARD_DIS))
    >>>> __hard_irq_disable();
    >>
    >> I have commented out the 2 lines.
    >
    > No, Only comment the test, you must absolutely leave the
    > __hard_irq_disable() call ! That's the whole point of the test, make
    > sure we unconditionally disable to see if that fixes the problem, in
    > which case that will tell us that we somewhere accidentally leave
    > irq_happened set to 0x01 while irqs are hard enabled.

    It can work.
    My system has been running for about 15 hours without crash.

    >
    > Cheers,
    > Ben.
    >
    >

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-04 01:41    [W:0.026 / U:0.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site