lkml.org 
[lkml]   [2012]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency
> From: Randy Dunlap [mailto:rdunlap@xenotime.net]
> Sent: Friday, April 27, 2012 6:38 PM
> To: Seth Jennings
> Cc: Greg Kroah-Hartman; devel@driverdev.osuosl.org; Dan Magenheimer; Autif Khan; Konrad Rzeszutek
> Wilk; linux-kernel@vger.kernel.org; linux-mm@kvack.org; Robert Jennings; Nitin Gupta
> Subject: Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency
>
> On 04/23/2012 06:33 PM, Seth Jennings wrote:
>
> > ZCACHE is a boolean in the Kconfig. When selected, it
> > should require that CRYPTO be builtin (=y).
> >
> > Currently, ZCACHE=y and CRYPTO=m is a valid configuration
> > when it should not be.
> >
> > This patch changes the zcache Kconfig to enforce this
> > dependency.
> >
> > Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
>
>
> Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Not sure if you need my approval, but I just in case you are waiting
for it:

Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>

> > ---
> > drivers/staging/zcache/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> > index 3ed2c8f..7048e01 100644
> > --- a/drivers/staging/zcache/Kconfig
> > +++ b/drivers/staging/zcache/Kconfig
> > @@ -2,7 +2,7 @@ config ZCACHE
> > bool "Dynamic compression of swap pages and clean pagecache pages"
> > # X86 dependency is because zsmalloc uses non-portable pte/tlb
> > # functions
> > - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> > + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
> > select ZSMALLOC
> > select CRYPTO_LZO
> > default n
>
>
>
> --
> ~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-05-03 23:41    [W:0.071 / U:0.604 seconds]
©2003-2014 Jasper Spaans. Advertise on this site