lkml.org 
[lkml]   [2012]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer
    On Thu, May 03, 2012 at 10:11:02PM +0200, Peter Zijlstra wrote:
    > On Thu, 2012-05-03 at 13:09 -0700, Linus Torvalds wrote:
    > > On Thu, May 3, 2012 at 1:02 PM, Peter Zijlstra <peterz@infradead.org> wrote:
    > > >
    > > > Thing is, with bonkers stuff like usb-console and kms/drm that's a _lot_
    > > > of code running under the logbuf/console locks.
    > >
    > > The top-level console lock shouldn't be a problem - we use trylock and
    > > delay if it is held.
    > >
    > > It's the lower-level driver-specific locks that screw us up. And quite
    > > frankly, I am *not* willing to say that that is a printk() problem.
    > > That is purely a "USB serial console is damn well broken" issue, and
    > > should not be considered a limitation of printk.
    >
    > I'm happy to call all that broken ;-)

    USB serial console was a drunken bet gone wrong. I'm amazed that it
    even works at times, and it should never be considered critical enough
    to affect any core kernel code.

    greg k-h


    \
     
     \ /
      Last update: 2012-05-03 22:21    [W:3.914 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site