lkml.org 
[lkml]   [2012]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] params: replace printk(KERN_<LVL>...) with pr_<lvl>(...)
From
Date
On Thu, 2012-05-03 at 13:12 -0600, Jim Cromie wrote:
> I left 1 printk which uses __FILE__, __LINE__ explicitly, which should
> not be subject to generic preferences expressed via pr_fmt().
[]
> diff --git a/kernel/params.c b/kernel/params.c
[]
> @@ -753,11 +747,9 @@ static struct module_kobject * __init locate_module_kobject(const char *name)
> #endif
> if (err) {
> kobject_put(&mk->kobj);
> - printk(KERN_ERR
> - "Module '%s' failed add to sysfs, error number %d\n",
> + pr_crit("Adding module '%s' to sysfs failed (%d), "
> + "the system may be unstable.\n",
> name, err);
> - printk(KERN_ERR
> - "The system will be unstable now.\n");
> return NULL;
> }
>

It'd be nicer to coalesce the formats and not worry about 80 columns.
Coalesced formats are easier to find via grep.

pr_crit("Adding module '%s' to sysfs failed (%d), the system may be unstable\n",




\
 
 \ /
  Last update: 2012-05-03 21:41    [from the cache]
©2003-2011 Jasper Spaans