lkml.org 
[lkml]   [2012]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3] params.c: fix Smack complaint about parse_args
    Date
    In commit 9fb48c744: "params: add 3rd arg to option handler callback
    signature", the if-guard added to the pr_debug was overzealous; no
    callers pass NULL, and existing code above and below the guard assumes
    as much. Change the if-guard to match, and silence the Smack
    complaint.

    CC: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
    ---
    kernel/params.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/kernel/params.c b/kernel/params.c
    index b60e2c7..be78c90 100644
    --- a/kernel/params.c
    +++ b/kernel/params.c
    @@ -190,7 +190,7 @@ int parse_args(const char *doing,
    /* Chew leading spaces */
    args = skip_spaces(args);

    - if (args && *args)
    + if (*args)
    pr_debug("doing %s, parsing ARGS: '%s'\n", doing, args);

    while (*args) {
    --
    1.7.8.1


    \
     
     \ /
      Last update: 2012-05-03 20:21    [W:4.165 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site