Messages in this thread | | | Date | Thu, 3 May 2012 11:45:32 -0400 | From | Chris Metcalf <> | Subject | Re: [PATCH v3] tilegx network driver: initial support |
| |
On 5/3/2012 1:41 AM, David Miller wrote: > From: Chris Metcalf <cmetcalf@tilera.com> > Date: Mon, 17 Sep 2001 00:00:00 -0400 > >> +/* #define USE_SIM_PRINTF */ >> + >> +#ifdef USE_SIM_PRINTF >> + >> +static __attribute__((unused, format (printf, 1, 2))) void >> +sim_printf(const char *format, ...) > ... >> +/* HACK: Allow use of "sim_printf()" instead of "printk()". */ >> +#define printk sim_printf >> + >> +#endif > This doesn't belong in a driver. > > You want a debugging console driver that uses that special SIM output > facility instead. > > Therefore, please remove this sim_printf stuff completely.
Thanks, I've removed it from my branch. (Since it's a trivial update, I won't repost the change on LKML unless I get any more feedback that needs addressing.)
I've checked in support for a "sim_console" boot flag that modifies the behavior of the tile-specific console driver to use the simulator output facility instead. I'll plan to push that to LKML with the next batch of changes I post.
-- Chris Metcalf, Tilera Corp. http://www.tilera.com
| |