lkml.org 
[lkml]   [2012]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [GIT PULL 0/5] perf/annotate fixes and improvements
    From
    Date
    Hi,

    2012-05-03 (목), 15:12 +0200, Peter Zijlstra:
    > On Thu, 2012-05-03 at 10:05 -0300, Arnaldo Carvalho de Melo wrote:
    > > > Also, in this case the asm is dark blue, which is nearly invisible on my
    > > > black background.
    > >
    > > What colour do you suggest? Also what kind of term color scheme do you
    > > use? Finding the right default combo is kinda hard.
    >
    > Yeah, I know.. I use white text on black background.
    >
    > Typically for vim I use :se bg=dark
    >
    > Anyway, I find it weird that the asm is coloured completely different
    > between the two modes. If anything I would keep the asm as in the
    > non-source variant and when you add the source, make that a different
    > colour.
    >

    It was changed on commit 58e817d997d1 ("perf annotate: Print asm code as
    blue when source code is displayed") by me. I just tried to make the
    output as same as the --stdio one, but I felt bad on printing the whole
    asm lines as blue when no source is shown - I use similar color scheme
    of yours - so I just ended up leaving it to the default white.

    Thanks,
    Namhyung



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-03 16:42    [W:0.025 / U:0.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site