Messages in this thread |  | | | Date | Thu, 03 May 2012 06:41:08 -0700 | | From | Eric Nelson <> | | Subject | Re: [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line |
| |
Thanks Joe,
On 05/02/2012 08:58 PM, Joe Perches wrote: > On Wed, 2012-05-02 at 20:32 -0700, Eric Nelson wrote: >> This tests for a bad habits of mine like this: >> >> return 0 ; >> >> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com> >> --- >> scripts/checkpatch.pl | 6 ++++++ >> 1 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >> index a3b9782..0e6977e 100755 >> --- a/scripts/checkpatch.pl >> +++ b/scripts/checkpatch.pl >> @@ -3227,6 +3227,12 @@ sub process { >> "Statements terminations use 1 semicolon\n" . $herecurr); >> } >> >> +# check for whitespace before semicolon - not allowed at end-of-line >> + if ($line =~ /\s+;$/) { > > if ($line =~ /\s+;\s*$/) > Won't the extra space at end of line be caught by other tests?
>> + WARN("SPACEBEFORE_SEMICOLON", > > WARN("SPACING", >
|  |