[lkml]   [2012]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/3] MFD: twl6040: Allocate IRQ numbers dynamically
    On 05/03/2012 04:20 PM, Mark Brown wrote:
    > On Thu, May 03, 2012 at 03:54:24PM +0300, Peter Ujfalusi wrote:
    >> /* In order to operate correctly we need valid interrupt config */
    >> - if (!client->irq || !pdata->irq_base) {
    >> + if (!client->irq) {
    > It looks like you're totally removing the use of irq_base which will
    > break any boards that didn't convert to DT. The usual idiom is to use
    > irq_base as the base for the range of requested IRQs if it's supplied,
    > otherwise set it to -1 to allow dynamic allocation. This should keep
    > existing users working without disruption.

    In the current board files the pdata->irq_base set to some #defined
    value (which is a comfortably big number).
    With irq_alloc_descs(-1, 0, nr_irqs, 0); the range which can accommodate
    the number of IRQs twl6040 will be provided so there is no need to me to
    use the board specified irq_base.
    The irq_base will be removed from the pdata structure, but that change
    will go via linux-omap to avoid compile breakage.
    This part is in preparation for DT, yes, but it is working without DT.
    The twl6040 irq range is mapped to different numbers, that's all.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2012-05-03 15:41    [W:0.023 / U:3.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site