lkml.org 
[lkml]   [2012]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3] MFD: twl6040: Code cleanup in interrupt initialization part
    Date
    No functional change, just to make the code a bit more uniform and
    remove wrapped lines.

    Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
    ---
    drivers/mfd/twl6040-irq.c | 17 ++++++++---------
    1 files changed, 8 insertions(+), 9 deletions(-)

    diff --git a/drivers/mfd/twl6040-irq.c b/drivers/mfd/twl6040-irq.c
    index b3f8dda..008022c 100644
    --- a/drivers/mfd/twl6040-irq.c
    +++ b/drivers/mfd/twl6040-irq.c
    @@ -138,7 +138,7 @@ static irqreturn_t twl6040_irq_thread(int irq, void *data)

    int twl6040_irq_init(struct twl6040 *twl6040)
    {
    - int cur_irq, ret;
    + int i, nr_irqs, ret;
    u8 val;

    mutex_init(&twl6040->irq_mutex);
    @@ -148,21 +148,20 @@ int twl6040_irq_init(struct twl6040 *twl6040)
    twl6040->irq_masks_cache = TWL6040_ALLINT_MSK;
    twl6040_reg_write(twl6040, TWL6040_REG_INTMR, TWL6040_ALLINT_MSK);

    + nr_irqs = ARRAY_SIZE(twl6040_irqs);
    /* Register them with genirq */
    - for (cur_irq = twl6040->irq_base;
    - cur_irq < twl6040->irq_base + ARRAY_SIZE(twl6040_irqs);
    - cur_irq++) {
    - irq_set_chip_data(cur_irq, twl6040);
    - irq_set_chip_and_handler(cur_irq, &twl6040_irq_chip,
    + for (i = twl6040->irq_base; i < twl6040->irq_base + nr_irqs; i++) {
    + irq_set_chip_data(i, twl6040);
    + irq_set_chip_and_handler(i, &twl6040_irq_chip,
    handle_level_irq);
    - irq_set_nested_thread(cur_irq, 1);
    + irq_set_nested_thread(i, 1);

    /* ARM needs us to explicitly flag the IRQ as valid
    * and will set them noprobe when we do so. */
    #ifdef CONFIG_ARM
    - set_irq_flags(cur_irq, IRQF_VALID);
    + set_irq_flags(i, IRQF_VALID);
    #else
    - irq_set_noprobe(cur_irq);
    + irq_set_noprobe(i);
    #endif
    }

    --
    1.7.8.6


    \
     
     \ /
      Last update: 2012-05-03 15:01    [W:0.022 / U:59.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site