[lkml]   [2012]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH RFC] virtio-net: remove useless disable on freeze
    On Thu, May 03, 2012 at 04:29:59PM +0530, Amit Shah wrote:
    > On (Wed) 04 Apr 2012 [12:19:55], Michael S. Tsirkin wrote:
    > > disable_cb is just an optimization: it
    > > can not guarantee that there are no callbacks.
    > Even then, what's the harm in keeping it? If indeed there's an
    > attempt to raise an interrupt after the host has been notified, it
    > will be suppressed.

    It won't. It's not a guarantee, e.g. with event index on
    it does nothing at all.

    > Also, disable_cb seems to be used elsewhere in the virtio_net.c file,
    > to suit similar purposes.
    > Amit


     \ /
      Last update: 2012-05-03 13:41    [W:0.022 / U:10.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site