lkml.org 
[lkml]   [2012]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v6 1/3] mmc: core: Add packed command feature of eMMC4.5
    Date
    Maya Erez <merez@codeaurora.org> wrote:
    > > @@ -1244,6 +1249,25 @@ static int mmc_init_card(struct mmc_host *host, u32
    > > ocr,
    > > }
    > > }
    > >
    > > + if ((host->caps2 & MMC_CAP2_PACKED_CMD) &&
    > > + (card->ext_csd.max_packed_writes > 0) &&
    > > + (card->ext_csd.max_packed_reads > 0)) {
    > > + err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
    > > + EXT_CSD_EXP_EVENTS_CTRL,
    > > + EXT_CSD_PACKED_EVENT_EN,
    > > + card->ext_csd.generic_cmd6_time);
    > > + if (err && err != -EBADMSG)
    > > + goto free_card;
    > > + if (err) {
    > > + pr_warning("%s: Enabling packed event failed\n",
    > > + mmc_hostname(card->host));
    > > + card->ext_csd.packed_event_en = 0;
    > > + err = 0;
    > > + } else {
    > > + card->ext_csd.packed_event_en = 1;
    > > + }
    > > + }
    > > +
    > The above shoud not be performed in case of resume. Therefore it needs to
    > be done only if (!oldcard)
    Could you explain the reason for this?

    Thanks,
    Seungwon Jeon
    >
    > Thanks,
    > Maya Erez
    > Consultant for Qualcomm Innovation Center, Inc.
    > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html



    \
     
     \ /
      Last update: 2012-05-30 02:41    [W:0.076 / U:30.996 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site