Messages in this thread | | | Date | Tue, 29 May 2012 19:45:42 +0400 | From | Glauber Costa <> | Subject | Re: [PATCH v3 05/28] memcg: Reclaim when more than one page needed. |
| |
On 05/29/2012 06:20 PM, Christoph Lameter wrote: > On Tue, 29 May 2012, Christoph Lameter wrote: > >>> * unlikely to succeed so close to the limit, and we fall back >>> * to regular pages anyway in case of failure. >>> */ >>> - if (nr_pages == 1&& ret) >>> + if (nr_pages<= (PAGE_SIZE<< PAGE_ALLOC_COSTLY_ORDER)&& ret) { > > Should this not be > > nr_pages<= 1<< PAGE_ALLOC_COSTLY_ORDER
I myself believe you are right.
Not sure if Suleiman had anything in mind that we're not seeing when he wrote this code?
| |