Messages in this thread | | | Date | Mon, 28 May 2012 15:42:59 +0100 | From | Andy Whitcroft <> | Subject | Re: [PATCH V3] checkpatch: check for whitespace before semicolon at EOL |
| |
On Sun, May 27, 2012 at 05:00:46PM -0700, Eric Nelson wrote: > Requires --strict option during invocation: > ~/linux$ scripts/checkpatch --strict foo.patch > > This tests for a bad habits of mine like this: > > return 0 ; > > Note that it does allow a special case of a bare semicolon > for empty loops: > > while (foo()) > ; > > Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com> > --- > scripts/checkpatch.pl | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index faea0ec..2262e1f 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2448,6 +2448,13 @@ sub process { > "space prohibited between function name and open parenthesis '('\n" . $herecurr); > } > } > + > +# check for whitespace before a non-naked semicolon > + if ($line =~ /^\+.*\S\s+;/) { > + CHK("SPACING", > + "space prohibited before semicolon\n" . $herecurr); > + } > +
Would this not also falsly trigger on 'for (foo = 10; foo; foo--) {' ?
> # Check operator spacing. > if (!($line=~/\#\s*include/)) { > my $ops = qr{
-apw
| |