lkml.org 
[lkml]   [2012]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 093/117] b43legacy: Fix error due to MMIO access with SSB unpowered
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Larry Finger <Larry.Finger@lwfinger.net>

    commit 8f4b20388fa77226a3605627a33a23f90d559e50 upstream.

    There is a dummy read of a PCI MMIO register that occurs before the SSB bus
    has been powered, which is an error. This bug has not been seen earlier,
    but was apparently exposed when udev was updated to version 182.

    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/wireless/b43legacy/main.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wireless/b43legacy/main.c
    index 1be214b..1deafaa 100644
    --- a/drivers/net/wireless/b43legacy/main.c
    +++ b/drivers/net/wireless/b43legacy/main.c
    @@ -1573,8 +1573,6 @@ static void b43legacy_request_firmware(struct work_struct *work)
    const char *filename;
    int err;

    - /* do dummy read */
    - ssb_read32(dev->dev, SSB_TMSHIGH);
    if (!fw->ucode) {
    if (rev == 2)
    filename = "ucode2";



    \
     
     \ /
      Last update: 2012-05-28 07:42    [W:4.143 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site