lkml.org 
[lkml]   [2012]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 04/16] pktcdvd: Switch to bio_kmalloc()
On Fri, May 25, 2012 at 01:25:27PM -0700, Kent Overstreet wrote:
> This is prep work for killing bi_destructor - previously, pktcdvd had
> its own pkt_bio_alloc which was basically duplication bio_kmalloc(),
> necessitating its own bi_destructor implementation.
>
> Signed-off-by: Kent Overstreet <koverstreet@google.com>
> Change-Id: I5604293e07f695c8f0106ae819e306f1def89a67
> ---
> drivers/block/pktcdvd.c | 115 ++++++++++++++++-------------------------------
> 1 file changed, 39 insertions(+), 76 deletions(-)
>
> diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
> index ba66e44..6fe693a 100644
> --- a/drivers/block/pktcdvd.c
> +++ b/drivers/block/pktcdvd.c
> @@ -522,36 +522,38 @@ static void pkt_bio_finished(struct pktcdvd_device *pd)
> }
> }
>
> -static void pkt_bio_destructor(struct bio *bio)
> +static void pkt_end_io_read(struct bio *bio, int err)

* Why isn't pktcdvd maintainer cc'd?

* How is it tested or why do you think this change is correct?

* Didn't Boaz point out that mixing function relocations and
functional changes makes the patch difficult to review and verify
already? Why doesn't the patch description mention function
relocations? And why are they mixed with functional changes?

--
tejun


\
 
 \ /
  Last update: 2012-05-28 03:41    [W:0.500 / U:0.640 seconds]
©2003-2014 Jasper Spaans. Advertise on this site