[lkml]   [2012]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v3 01/16] block: Generalized bio pool freeing
    Hello, Kent.

    On Fri, May 25, 2012 at 01:25:24PM -0700, Kent Overstreet wrote:
    > With the old code, when you allocate a bio from a bio pool you have to
    > implement your own destructor that knows how to find the bio pool the
    > bio was originally allocated from.
    > This adds a new field to struct bio (bi_pool) and changes
    > bio_alloc_bioset() to use it. This makes various bio destructors
    > unnecessary, so they're then deleted.
    > Signed-off-by: Kent Overstreet <>
    > Change-Id: I5eb66c1d6910757f4af8755b8857dcbe4619cf8d

    In the previous review, I made two requests about this patch.

    * Please improve description.

    * Please lose Change-Id.

    None of which seems to have happened and my Acked-by isn't added
    either. Come on. Give me some reason to keep reviewing this stuff.
    A couple more suggestions.

    * If this goes in, it will go through Jens' block tree. Better keep
    him cc'd.

    * It's generally a good idea to have Cc: tags in the description
    footer for the maintainers of the affected subsystems.



     \ /
      Last update: 2012-05-28 03:41    [W:0.021 / U:9.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site