Messages in this thread |  | | | Date | Sat, 26 May 2012 13:30:46 +0200 | | From | Sascha Hauer <> | | Subject | Re: [PATCH 04/15] dma: imx-sdma: Use clk_prepare_enable/clk_disable_unprepare |
| |
On Fri, May 25, 2012 at 08:14:45PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Prepare the clock before enabling it. > > Cc: Vinod Koul <vinod.koul@intel.com> > Cc: <linux-kernel@vger.kernel.org> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > drivers/dma/imx-sdma.c | 28 ++++++++++++++-------------- > 1 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index fb4f499..b6174e6 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -868,8 +868,8 @@ static int sdma_alloc_chan_resources(struct dma_chan *chan) > sdmac->peripheral_type = data->peripheral_type; > sdmac->event_id0 = data->dma_request; > > - clk_enable(sdmac->sdma->clk_ipg); > - clk_enable(sdmac->sdma->clk_ahb); > + clk_prepare_enable(sdmac->sdma->clk_ipg); > + clk_prepare_enable(sdmac->sdma->clk_ahb);
No, the clock already is prepared, see the probe function.
Sascha
-- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
|  |