[lkml]   [2012]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: exit_mmap BUG_ON in 2.6.23 (and Add qdisc __NET_XMIT_STOLEN)
    On Fri, 2012-05-25 at 17:28 -0700, Sam Portolla wrote:

    Please don't top post on this list

    > [pease cc on the replies; not a member of this
    > mailer]
    > Hi Hugh,
    > Thank you! It turns out our 2.6.23 kernel does not have this old
    > patch, I am also adding Jarek, David and Patrick who were involved in
    > the below fix for their insights:
    > commit 378a2f090f7a478704a372a4869b8a9ac206234e
    > Date: Mon Aug 4 22:31:03 2008 -0700
    > net_sched: Add qdisc __NET_XMIT_STOLEN flag
    > In this failure case below, as well as some others, the ethernet
    > driver printed a transmit timeout just before the crash.
    > It seems since we don't have the above patch, the kernel qdisc Tx
    > packet path for fragmented packets can be messed up and corrupt the
    > skb it passes to drivers, which in the historic case that led to
    > above fix, caused an skb NULL ptr de-ref in the driver itself (which
    > we also saw once).
    > Jarek, David or Patrick,
    > Could the lack of above patch cause the kernel to also falsely detect
    > transmit timeouts on various drivers as it can not properly keep track
    > of packets transmitted? Can you please elaborate so a newbie like me
    > can understand?
    > Is the above commit the sole one required for the kernel panic/skb
    > NULL de-ref driver issue or is there more needed fixes later on that
    > can be backported to an older kernel (2.6.23 GNU/Linux x86_64)?

    Transmit timeouts are because of races in some network drivers.

    The device stay in XOFF state for too long time (forever as a matter of
    fact once the race triggered)

    Since 2.6.23 we fixed a lot of them, but still races still exist.

     \ /
      Last update: 2012-05-26 07:01    [W:0.050 / U:6.644 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site