lkml.org 
[lkml]   [2012]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 48/55] media: uvcvideo: Fix ENUMINPUT handling
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    commit 31c5f0c5e25ed71eeced170f113bb590f2f1f6f3 upstream.

    Properly validate the user-supplied index against the number of inputs.
    The code used the pin local variable instead of the index by mistake.

    Reported-by: Jozef Vesely <vesely@gjh.sk>
    Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/media/video/uvc/uvc_v4l2.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/media/video/uvc/uvc_v4l2.c
    +++ b/drivers/media/video/uvc/uvc_v4l2.c
    @@ -710,7 +710,7 @@ static long uvc_v4l2_do_ioctl(struct fil
    break;
    }
    pin = iterm->id;
    - } else if (pin < selector->bNrInPins) {
    + } else if (index < selector->bNrInPins) {
    pin = selector->baSourceID[index];
    list_for_each_entry(iterm, &chain->entities, chain) {
    if (!UVC_ENTITY_IS_ITERM(iterm))



    \
     
     \ /
      Last update: 2012-05-27 03:41    [W:0.023 / U:120.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site