lkml.org 
[lkml]   [2012]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] usb: gadget: f_mass_storage: change default value of the removable parameter
    Date
    This commit changes the default value of the removable module parameter
    from “y” to “n”. This comes with line with file_storag's default and
    seems to be a better default.

    Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
    ---
    drivers/usb/gadget/f_mass_storage.c | 6 ++----
    1 files changed, 2 insertions(+), 4 deletions(-)

    Alternatively I can add a warning about the default being changed and
    schedule the change for the future. Dunno if it's worth it.

    diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
    index f67b453..72116fa 100644
    --- a/drivers/usb/gadget/f_mass_storage.c
    +++ b/drivers/usb/gadget/f_mass_storage.c
    @@ -124,7 +124,7 @@
    * backing storage.
    * ro=b[,b...] Default false, boolean for read-only access.
    * removable=b[,b...]
    - * Default true, boolean for removable media.
    + * Default false, boolean for removable media.
    * cdrom=b[,b...] Default false, boolean for whether to emulate
    * a CD-ROM drive.
    * nofua=b[,b...] Default false, booleans for ignore FUA flag
    @@ -3167,8 +3167,7 @@ fsg_config_from_params(struct fsg_config *cfg,
    for (i = 0, lun = cfg->luns; i < cfg->nluns; ++i, ++lun) {
    lun->ro = !!params->ro[i];
    lun->cdrom = !!params->cdrom[i];
    - lun->removable = /* Removable by default */
    - params->removable_count <= i || params->removable[i];
    + lun->removable = !!params->removable[i];
    lun->filename =
    params->file_count > i && params->file[i][0]
    ? params->file[i]
    @@ -3203,4 +3202,3 @@ fsg_common_from_params(struct fsg_common *common,
    fsg_config_from_params(&cfg, params);
    return fsg_common_init(common, cdev, &cfg);
    }
    -
    --
    1.7.7.3
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-27 02:21    [W:0.027 / U:30.356 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site