lkml.org 
[lkml]   [2012]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] perf record: fix branch_stack type in perf_record_opts

The attr.branch_sample_type field is defined as u64 by the API.
As such, we need to ensure the variable holding the value of the
branch stack filters is also u64 otherwise we may lose bits in
the future.

Note also that the bogus definition of the field in
perf_record_opts caused problems on big-endian PPC systems.
Thanks to Anshuman Khandual for tracking the problem on PPC.

Signed-off-by: Stephane Eranian <eranian@google.com>
---
diff --git a/tools/perf/perf.h b/tools/perf/perf.h
index 14f1034..f960ccb 100644
--- a/tools/perf/perf.h
+++ b/tools/perf/perf.h
@@ -227,7 +227,7 @@ struct perf_record_opts {
unsigned int freq;
unsigned int mmap_pages;
unsigned int user_freq;
- int branch_stack;
+ u64 branch_stack;
u64 default_interval;
u64 user_interval;
};

\
 
 \ /
  Last update: 2012-05-25 23:41    [from the cache]
©2003-2011 Jasper Spaans