Messages in this thread Patch in this message | | | Subject | Re: [tip:sched/core] sched/numa: Rewrite the CONFIG_NUMA sched domain support | From | Peter Zijlstra <> | Date | Fri, 25 May 2012 09:31:20 +0200 |
| |
On Thu, 2012-05-24 at 14:23 -0700, Tony Luck wrote: > Changing both the kzalloc_node() calls in sched_init_numa() > into plain kzalloc() calls seems to fix things. So it looks like we are trying > to allocate on a node before the node has been fully set up.
Right,.. and its not too important either, so lets just use regular allocations.
That said, I can only find the 1 alloc_node() in sched_init_numa()
--- Subject: sched: Don't try allocating memory from offline nodes From: Peter Zijlstra <a.p.zijlstra@chello.nl> Date: Fri May 25 09:26:43 CEST 2012
Allocators don't appreciate it when you try and allocate memory from offline nodes.
Reported-by: Tony Luck <tony.luck@intel.com> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> --- kernel/sched/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Index: linux-2.6/kernel/sched/core.c =================================================================== --- linux-2.6.orig/kernel/sched/core.c +++ linux-2.6/kernel/sched/core.c @@ -6449,7 +6449,7 @@ static void sched_init_numa(void) return; for (j = 0; j < nr_node_ids; j++) { - struct cpumask *mask = kzalloc_node(cpumask_size(), GFP_KERNEL, j); + struct cpumask *mask = kzalloc(cpumask_size(), GFP_KERNEL); if (!mask) return;
| |