Messages in this thread |  | | | Date | Fri, 25 May 2012 15:57:53 +0530 | | From | Laxman Dewangan <> | | Subject | Re: [PATCH 1/9 v3] dmaengine: add an shdma-base library |
| |
On Friday 25 May 2012 01:45 PM, Vinod Koul wrote: > On Fri, 2012-05-18 at 10:21 +0200, Guennadi Liakhovetski wrote:
> +/* >>>> + * Drivers, using this library are expected to embed struct shdma_dev, >>>> + * struct shdma_chan, struct shdma_desc, and struct shdma_slave >>>> + * in their respective device, channel, descriptor and slave objects. >>>> + */ >>>> + >>>> +struct shdma_slave { >>>> + unsigned int slave_id; >>> this should be moved to struct dma_slave_config >> Again, this would be a functional change. And struct dma_slave_config >> doesn't have a slave-ID field in it, which is the only thing we need for >> now. Instead it has a bunch of other fields, of which none is so far used >> by this driver. >>
In Nvidia's tegra SOC also require to pass the slave id from client to dma driver. I have pushed the change to make it part of struct dma_slave_config on the patch [PATCH V4 1/2] dma: dmaengine: add slave req id in slave_config
So hope you can use the same if that patch get merged.
|  |