lkml.org 
[lkml]   [2012]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] Staging: ipack/bridges/tpci200: remove TPCI200_SHORTNAME constant
    On Wed, May 23, 2012 at 12:13:21PM +0200, Samuel Iglesias Gonsálvez wrote:
    > On Fri, 2012-05-18 at 17:37 -0700, Greg Kroah-Hartman wrote:
    > [...]
    > > > if (dev->slot >= TPCI200_NB_SLOT) {
    > > > - pr_info("Slot [%s %d:%d] doesn't exist! Last tpci200 slot is %d.\n",
    > > > - TPCI200_SHORTNAME, dev->bus_nr, dev->slot,
    > > > - TPCI200_NB_SLOT-1);
    > > > + pr_info("Slot [%d:%d] doesn't exist! Last tpci200 slot is %d.\n",
    > > > + dev->bus_nr, dev->slot, TPCI200_NB_SLOT-1);
    > >
    > > All of these should really be dev_err() calls, right?
    > >
    > > You should have no pr_* calls at all in any driver, and probably none in
    > > the ipack core as well, care to fix them all up?
    >
    > Yes, I will fix it in the next bunch of patches. I don't forget it.
    >
    > By the way, sometime ago, you suggested me to use the ics interface for
    > giving the bus number if there is no HW boundary of the number of them.
    > However, I searched the source code and I didn't find any reference to
    > the ics interface. Can you tell me where is it declared?

    My appologies, I should have said "idr" interface, there is a reason why
    you couldn't find any "ics" code :)

    Sorry about that,

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-23 18:41    [W:0.032 / U:30.820 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site