Messages in this thread | | | Date | Mon, 21 May 2012 21:18:44 +0200 | From | Richard Cochran <> | Subject | Re: [PATCH RFC V2 4/6] time: introduce leap second functional interface |
| |
On Mon, May 21, 2012 at 11:01:03AM -0700, John Stultz wrote: > On 05/18/2012 07:09 AM, Richard Cochran wrote: > >+ > >+int timekeeping_gettod_status(struct timespec *ts, time_t *offset); > >+ > >+void timekeeping_delete_leap_second(void); > >+ > >+void timekeeping_finish_leap_second(void); > >+ > >+void timekeeping_insert_leap_second(void); > >+ > >+#endif > > Why not just add these to time.h?
This is a private interface only for ntp.c, not for the whole rest of the kernel via time.h.
BTW this highlights the very icky incestuous relationship between ntp.c and timekeeper.c. Probably there should be a comment documenting the (unspoken) locking sequence for ntp_lock and timekeeper.lock.
Thanks, Richard
| |