lkml.org 
[lkml]   [2012]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/7] [RFC] UBI: Export next_sqnum()
    On 21.05.2012 16:00, Artem Bityutskiy wrote:
    > On Mon, 2012-05-21 at 15:34 +0200, Richard Weinberger wrote:
    >>> + /* TODO: Before checking version - check the CRC.
    >>
    >> The CRC covers only the fastmap data, not the super block.
    >
    > Everything should be protected with CRC.

    Okay, done. :)

    >>> for (i = 0; i< nblocks; i++) {
    >>> + /* TODO: you basically perform the scanning here - you should
    >>> + * share the same code as we use in scan.c: use process_peb().
    >>> + */
    >>
    >> What exactly do you mean by that?
    >> process_eb() will not help much because the fastmap data is written
    >> "raw" to the flash. (Without any interaction from the WL sub-system)
    >
    > It still contains EC and VID headers. So you can use the existing code
    > for scanning it.

    I use already ubi_io_read_vid_hdr() and ubi_io_read_ec_hdr() what should
    I reuse?
    Also checking the image sequence would make sense.

    Thanks,
    //richard


    \
     
     \ /
      Last update: 2012-05-21 17:02    [W:4.339 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site