lkml.org 
[lkml]   [2012]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] scripts/patch-kernel: fix typos and compression comment
    On 21.5.2012 04:49, Randy Dunlap wrote:
    > From: Randy Dunlap <rdunlap@xenotime.net>
    >
    > Fix typo, drop trailing whitespace, and add "xz" to list of
    > compression types supported.
    >
    > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
    > ---
    > scripts/patch-kernel | 6 +++---
    > 1 file changed, 3 insertions(+), 3 deletions(-)
    >
    > --- lnx-34-rc7-pk.orig/scripts/patch-kernel
    > +++ lnx-34-rc7-pk/scripts/patch-kernel
    > @@ -26,8 +26,8 @@
    > #
    > # Nick Holloway <Nick.Holloway@alfie.demon.co.uk>, 2nd January 1995.
    > #
    > -# Added support for handling multiple types of compression. What includes
    > -# gzip, bzip, bzip2, zip, compress, and plaintext.
    > +# Added support for handling multiple types of compression. That includes
    > +# gzip, bzip, bzip2, zip, compress, xz, and plaintext.
    > #
    > # Adam Sulmicki <adam@cfar.umd.edu>, 1st January 1997.

    You are editing a changelog entry from time when xz did not exist. Why
    don't you instead add a note to the usage examples at the beginning of
    the script, that several compression formats are supported.

    BTW, are you actually *using* this script? Wow, that would be two
    confirmed users in this calendar year alone :).

    Michal


    \
     
     \ /
      Last update: 2012-05-21 14:01    [W:0.027 / U:29.824 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site