lkml.org 
[lkml]   [2012]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]ipc:fixed spacing issues in coding style.
On Sun, May 20, 2012 at 04:31:13PM +0530, Jeffrin Jose wrote:
> Fixed spacing issues related to different operators
> like * and : found by checkpatch.pl tool in ipc/sem.c
>
> Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>

All three of the spacing fixes in this patch look correct.
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

However, I see one instance of another type of spacing issue in the
patch context:

> --- a/ipc/sem.c
> +++ b/ipc/sem.c
> @@ -964,7 +964,7 @@ static int semctl_nolock(struct ipc_namespace *ns, int semid,
> up_read(&sem_ids(ns).rw_mutex);
> if (copy_to_user (arg.__buf, &seminfo, sizeof(struct seminfo)))

copy_to_user should not have a space before its open parenthesis.

- Josh Triplett


\
 
 \ /
  Last update: 2012-05-20 21:41    [W:0.130 / U:0.276 seconds]
©2003-2014 Jasper Spaans. Advertise on this site