[lkml]   [2012]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[RFC/PATCH] mptscsih: Set DRIVER_SENSE when sense data present
    While looking into some drive errors on a few of our systems I noticed that
    DRIVER_SENSE was not being set by mptscsih even though there was sense data
    present. DRIVER_SENSE does eventually get set by scsi_finish_command() when
    it detects the sense data. I won't pretend I'm an expert in this area, I'm
    just looking for an explanation as to why the patch below or something like
    it is not currently in the driver? Is it sufficient enough that we're detecting
    this case later on in the scsi code?



    Currently when sense data is present only check condition is set. This
    sets DRIVER_SENSE as well.

    Signed-off-by: Josh Hunt <>
    drivers/message/fusion/mptscsih.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/drivers/message/fusion/mptscsih.c b/drivers/message/fusion/mptscsih.c
    index 0c3ced7..3ccf5cf 100644
    --- a/drivers/message/fusion/mptscsih.c
    +++ b/drivers/message/fusion/mptscsih.c
    @@ -889,6 +889,8 @@ mptscsih_io_done(MPT_ADAPTER *ioc, MPT_FRAME_HDR *mf, MPT_FRAME_HDR *mr)
    } else if (scsi_state &

    + sc->result |= (DRIVER_SENSE << 24);
    * For potential trouble on LSI53C1030.
    * (date:2007.xx.)

     \ /
      Last update: 2012-05-20 17:01    [W:0.022 / U:34.400 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site