Messages in this thread | | | Date | Wed, 2 May 2012 10:58:56 +0200 | Subject | Re: [PATCH] mwl8k: Add 0x2a02 PCI device-id (Marvell 88W8361) | From | Sedat Dilek <> |
| |
On Wed, May 2, 2012 at 4:38 AM, Lennert Buytenhek <buytenh@wantstofly.org> wrote: > On Tue, May 01, 2012 at 09:12:25PM -0400, Pat Erley wrote: > >> >--- a/drivers/net/wireless/mwl8k.c >> >+++ b/drivers/net/wireless/mwl8k.c >> >@@ -5225,6 +5225,7 @@ static void mwl8k_finalize_join_worker(struct work_struct *work) >> > } >> > >> > enum { >> >+ MWL8361P = 0, >> > MWL8363 = 0, >> > MWL8687, >> > MWL8366, >> >> I'm not an expert, but isn't this giving both 8361P and 8363 the >> same values in the enum? > > Yeah, this is broken.
Before this email, Helmut pointed me to the enum thingie in a private query. As I was busy with OverlayFS the last days, I couldn't give that information back.
So, this should be: ... enum { MWL8361P = 0, MWL8363, MWL8687, MWL8366, ...
Shall I cook up a new patch with a proper history and documented origin (original patch is from OpenWrt, I refreshed it against upstream)? ...add some Tested-by (Helmut, Jim)... ...send that to linux-wireless ML for a review?
- Sedat - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |